Hacker News
new
|
past
|
comments
|
ask
|
show
|
jobs
|
submit
login
rcxdude
15 days ago
|
parent
|
context
|
favorite
| on:
Mistakes I see engineers making in their code revi...
That is a bit overzealous. It makes sense for CI where you don't want to waste running tests on an already failing build, but for local builds you probably want to allow warnings and be able to run tests, lints, and formatting checks separately.
hinkley
15 days ago
[–]
I will probably file a PR to flip them around. Since the runscript will stop on a broken test it’ll work better for local.
And then there’s the duplication and differences between the runscripts and the GitHub actions…
Consider applying for YC's Winter 2026 batch! Applications are open till Nov 10
Guidelines
|
FAQ
|
Lists
|
API
|
Security
|
Legal
|
Apply to YC
|
Contact
Search: